generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge "syscall(3)'s return type should be long."

Browse Source
This commit is contained in:
Elliott Hughes 2014-07-28 22:33:51 +00:00 committed by Gerrit Code Review
commit 8a2ecf868f
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libc/include/sys/syscall.h
View File

@ -37,7 +37,7 @@
__BEGIN_DECLS __BEGIN_DECLS
int syscall(int number, ...); long syscall(long number, ...);
__END_DECLS __END_DECLS

9
tests/unistd_test.cpp
View File

@ -20,6 +20,7 @@
#include <errno.h> #include <errno.h>
#include <fcntl.h> #include <fcntl.h>
#include <limits.h>
#include <stdint.h> #include <stdint.h>
#include <unistd.h> #include <unistd.h>
#include <sys/syscall.h> #include <sys/syscall.h>
@ -212,6 +213,14 @@ TEST(unistd, read_EBADF) {
ASSERT_EQ(EBADF, errno); ASSERT_EQ(EBADF, errno);
} }
TEST(unistd, syscall_long) {
// Check that syscall(3) correctly returns long results.
// https://code.google.com/p/android/issues/detail?id=73952
// We assume that the break is > 4GiB, but this is potentially flaky.
uintptr_t p = reinterpret_cast<uintptr_t>(sbrk(0));
ASSERT_EQ(p, static_cast<uintptr_t>(syscall(__NR_brk, 0)));
}
TEST(unistd, alarm) { TEST(unistd, alarm) {
ASSERT_EQ(0U, alarm(0)); ASSERT_EQ(0U, alarm(0));
} }