generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Ensure __set_errno is still visible on LP32.

Browse Source 
The use of the .hidden directive to avoid going via the PLT for
__set_errno had the side-effect of actually making __set_errno
hidden (which is odd because assembler directives don't usually
affect symbols defined in a different file --- you can't even
create a weak reference to a symbol that's defined in a different
file).

This change switches the system call stubs over to a new always-hidden
__set_errno_internal and has a visible __set_errno on LP32 just for
binary compatibility with old NDK apps.

Bug: 17423135
Change-Id: I6b6d7a05dda85f923d22e5ffd169a91e23499b7b
This commit is contained in:
Elliott Hughes
2014-09-08 15:25:01 -07:00
parent c8f6b82f87
commit 7efad83d43
1177 changed files with 1194 additions and 3506 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libc/arch-mips/syscalls/__exit.S
View File

@@ -2,8 +2,6 @@
#include <private/bionic_asm.h>
.hidden __set_errno
ENTRY(__exit)
.set noreorder
.cpload t9
@@ -14,7 +12,7 @@ ENTRY(__exit)
j ra
nop
1:
la t9,__set_errno
la t9,__set_errno_internal
j t9
nop
.set reorder