diff --git a/linker/linker.cpp b/linker/linker.cpp index 94672a87a..d29ee027a 100644 --- a/linker/linker.cpp +++ b/linker/linker.cpp @@ -1765,14 +1765,8 @@ static ElfW(Addr) get_addend(ElfW(Rel)* rel, ElfW(Addr) reloc_addr) { #endif template -bool soinfo::relocate(ElfRelIteratorT&& rel_iterator, const soinfo_list_t& global_group, - const soinfo_list_t& local_group) { - VersionTracker version_tracker; - - if (!version_tracker.init(this)) { - return false; - } - +bool soinfo::relocate(const VersionTracker& version_tracker, ElfRelIteratorT&& rel_iterator, + const soinfo_list_t& global_group, const soinfo_list_t& local_group) { for (size_t idx = 0; rel_iterator.has_next(); ++idx) { const auto rel = rel_iterator.next(); if (rel == nullptr) { @@ -2851,6 +2845,12 @@ bool soinfo::link_image(const soinfo_list_t& global_group, const soinfo_list_t& local_group_root_ = this; } + VersionTracker version_tracker; + + if (!version_tracker.init(this)) { + return false; + } + #if !defined(__LP64__) if (has_text_relocations) { // Make segments writable to allow text relocations to work properly. We will later call @@ -2879,6 +2879,7 @@ bool soinfo::link_image(const soinfo_list_t& global_group, const soinfo_list_t& const size_t packed_relocs_size = android_relocs_size_ - 4; relocated = relocate( + version_tracker, packed_reloc_iterator( sleb128_decoder(packed_relocs, packed_relocs_size)), global_group, local_group); @@ -2895,26 +2896,30 @@ bool soinfo::link_image(const soinfo_list_t& global_group, const soinfo_list_t& #if defined(USE_RELA) if (rela_ != nullptr) { DEBUG("[ relocating %s ]", get_soname()); - if (!relocate(plain_reloc_iterator(rela_, rela_count_), global_group, local_group)) { + if (!relocate(version_tracker, + plain_reloc_iterator(rela_, rela_count_), global_group, local_group)) { return false; } } if (plt_rela_ != nullptr) { DEBUG("[ relocating %s plt ]", get_soname()); - if (!relocate(plain_reloc_iterator(plt_rela_, plt_rela_count_), global_group, local_group)) { + if (!relocate(version_tracker, + plain_reloc_iterator(plt_rela_, plt_rela_count_), global_group, local_group)) { return false; } } #else if (rel_ != nullptr) { DEBUG("[ relocating %s ]", get_soname()); - if (!relocate(plain_reloc_iterator(rel_, rel_count_), global_group, local_group)) { + if (!relocate(version_tracker, + plain_reloc_iterator(rel_, rel_count_), global_group, local_group)) { return false; } } if (plt_rel_ != nullptr) { DEBUG("[ relocating %s plt ]", get_soname()); - if (!relocate(plain_reloc_iterator(plt_rel_, plt_rel_count_), global_group, local_group)) { + if (!relocate(version_tracker, + plain_reloc_iterator(plt_rel_, plt_rel_count_), global_group, local_group)) { return false; } } diff --git a/linker/linker.h b/linker/linker.h index 06e1f53a6..109aeb720 100644 --- a/linker/linker.h +++ b/linker/linker.h @@ -344,8 +344,8 @@ struct soinfo { void call_array(const char* array_name, linker_function_t* functions, size_t count, bool reverse); void call_function(const char* function_name, linker_function_t function); template - bool relocate(ElfRelIteratorT&& rel_iterator, const soinfo_list_t& global_group, - const soinfo_list_t& local_group); + bool relocate(const VersionTracker& version_tracker, ElfRelIteratorT&& rel_iterator, + const soinfo_list_t& global_group, const soinfo_list_t& local_group); private: // This part of the structure is only available diff --git a/linker/linker_mips.cpp b/linker/linker_mips.cpp index aaf8b5e51..3402afe68 100644 --- a/linker/linker_mips.cpp +++ b/linker/linker_mips.cpp @@ -32,25 +32,22 @@ #include "linker_reloc_iterators.h" #include "linker_sleb128.h" -template bool soinfo::relocate(plain_reloc_iterator&& rel_iterator, +template bool soinfo::relocate(const VersionTracker& version_tracker, + plain_reloc_iterator&& rel_iterator, const soinfo_list_t& global_group, const soinfo_list_t& local_group); template bool soinfo::relocate>( + const VersionTracker& version_tracker, packed_reloc_iterator&& rel_iterator, const soinfo_list_t& global_group, const soinfo_list_t& local_group); template -bool soinfo::relocate(ElfRelIteratorT&& rel_iterator, +bool soinfo::relocate(const VersionTracker& version_tracker, + ElfRelIteratorT&& rel_iterator, const soinfo_list_t& global_group, const soinfo_list_t& local_group) { - VersionTracker version_tracker; - - if (!version_tracker.init(this)) { - return false; - } - for (size_t idx = 0; rel_iterator.has_next(); ++idx) { const auto rel = rel_iterator.next();