generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Check memory size on FD_* functions

Browse Source 
Make sure the buffer we're dealing with has enough room.
Might as well check for memory issues while we're here,
even though I don't imagine they'll happen in practice.

Change-Id: I0ae1f0f06aca9ceb91e58c70183bb14e275b92b5
This commit is contained in:
Nick Kralevich
2013-10-03 14:08:39 -07:00
parent 6088047a64
commit 7943df62f7
3 changed files with 37 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/fortify_test.cpp
View File

@@ -554,6 +554,20 @@ TEST(DEATHTEST, FD_ISSET_fortified) {
ASSERT_EXIT(FD_ISSET(-1, &set), testing::KilledBySignal(SIGABRT), "");
}
TEST(DEATHTEST, FD_ISSET_2_fortified) {
::testing::FLAGS_gtest_death_test_style = "threadsafe";
char buf[1];
fd_set* set = (fd_set*) buf;
ASSERT_EXIT(FD_ISSET(0, set), testing::KilledBySignal(SIGABRT), "");
}
TEST(DEATHTEST, FD_ZERO_fortified) {
::testing::FLAGS_gtest_death_test_style = "threadsafe";
char buf[1];
fd_set* set = (fd_set*) buf;
ASSERT_EXIT(FD_ZERO(set), testing::KilledBySignal(SIGABRT), "");
}
extern "C" char* __strncat_chk(char*, const char*, size_t, size_t);
extern "C" char* __strcat_chk(char*, const char*, size_t);