generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Prevent spurious EINTR to freeze process debugging

Browse Source
This commit is contained in:
David 'Digit' Turner 2009-10-16 12:13:34 -07:00
parent 5f32207a3d
commit 7934a799e1
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
linker/debugger.c
View File

@ -32,6 +32,7 @@
#include <ctype.h> #include <ctype.h>
#include <signal.h> #include <signal.h>
#include <sys/mman.h> #include <sys/mman.h>
#include <errno.h>
#include "linker.h" #include "linker.h"
@ -40,6 +41,11 @@
void notify_gdb_of_libraries(); void notify_gdb_of_libraries();
#define RETRY_ON_EINTR(ret,cond) \
do { \
ret = (cond); \
} while (ret < 0 && errno == EINTR)
void debugger_signal_handler(int n) void debugger_signal_handler(int n)
{ {
unsigned tid; unsigned tid;
@ -58,10 +64,15 @@ void debugger_signal_handler(int n)
* is paranoid and will verify that we are giving a tid * is paranoid and will verify that we are giving a tid
* that's actually in our process * that's actually in our process
*/ */
write(s, &tid, sizeof(unsigned)); int ret;
read(s, &tid, 1); RETRY_ON_EINTR(ret, write(s, &tid, sizeof(unsigned)));
notify_gdb_of_libraries(); if (ret == sizeof(unsigned)) {
/* if the write failed, there is no point to read on
* the file descriptor. */
RETRY_ON_EINTR(ret, read(s, &tid, 1));
notify_gdb_of_libraries();
}
close(s); close(s);
} }