Cosmetic changes to netd client files.
+ Name the dispatch header correctly (NetdClientDispatch.h). + Hide the global dispatch variable (__netdClientDispatch). + Explain why it's okay to read the variable without locking. + Use quotes instead of angle-brackets for non-system includes. + Add necessary declarations for C compiles (and not just C++). Change-Id: Id0932165e71d81da5fce77a684f40c2263f58e61
This commit is contained in:
@@ -14,7 +14,7 @@
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
#include <private/NetdClient.h>
|
||||
#include "private/NetdClientDispatch.h"
|
||||
|
||||
#ifdef __i386__
|
||||
#define __socketcall __attribute__((__cdecl__))
|
||||
@@ -25,7 +25,9 @@
|
||||
extern "C" __socketcall int __accept(int, sockaddr*, socklen_t*);
|
||||
extern "C" __socketcall int __connect(int, const sockaddr*, socklen_t);
|
||||
|
||||
NetdClientDispatch __netdClientDispatch __attribute__((aligned(32))) = {
|
||||
// This structure is modified only at startup (when libc.so is loaded) and never
|
||||
// afterwards, so it's okay that it's read later at runtime without a lock.
|
||||
__LIBC_HIDDEN__ NetdClientDispatch __netdClientDispatch __attribute__((aligned(32))) = {
|
||||
__accept,
|
||||
__connect,
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user