generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix sys_stat.mkfifo when not run as root.

Browse Source 
It's not allowed for a shell user to create a fifo in /data/local/tmp.
Make the test do nothing if not run as root.

Bug: 17646702
Change-Id: I932262fa233eae8b5dd607a2398a47c50a208701
This commit is contained in:
Christopher Ferris 2014-09-24 16:01:18 -07:00
parent 086bb382db
commit 6c69afdb6d
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tests/sys_stat_test.cpp
View File

@ -56,18 +56,22 @@ TEST(sys_stat, futimens_EBADF) {
}
TEST(sys_stat, mkfifo) {
// Racy but probably sufficient way to get a suitable filename.
std::string path;
{
TemporaryFile tf;
path = tf.filename;
}
if (getuid() == 0) {
// Racy but probably sufficient way to get a suitable filename.
std::string path;
{
TemporaryFile tf;
path = tf.filename;
}
ASSERT_EQ(0, mkfifo(path.c_str(), 0666));
struct stat sb;
ASSERT_EQ(0, stat(path.c_str(), &sb));
ASSERT_TRUE(S_ISFIFO(sb.st_mode));
unlink(path.c_str());
ASSERT_EQ(0, mkfifo(path.c_str(), 0666));
struct stat sb;
ASSERT_EQ(0, stat(path.c_str(), &sb));
ASSERT_TRUE(S_ISFIFO(sb.st_mode));
unlink(path.c_str());
} else {
GTEST_LOG_(INFO) << "This test only performs a test when run as root.";
}
}
TEST(sys_stat, stat64_lstat64_fstat64) {