generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix the printf family for non-ASCII.

Browse Source 
The bug here turned out to be that we hadn't increased the constant
corresponding to the maximum number of bytes in a character to match
our new implementation, so any character requiring more than a byte
in UTF-8 would break our printf family.

Bug: 15439554
Change-Id: I693e5e6eb11c640b5886e848502908ec5fff53b1
This commit is contained in:
Elliott Hughes
2014-06-05 20:10:09 -07:00
parent 8aabecf35c
commit 69f05d291d
4 changed files with 50 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/stdio_test.cpp
View File

@@ -426,7 +426,26 @@ TEST(stdio, snprintf_negative_zero_5084292) {
EXPECT_STREQ("-0.000000", buf);
}
TEST(stdio, snprintf_utf8_15439554) {
// http://b/15439554
char buf[BUFSIZ];
// 1-byte character.
snprintf(buf, sizeof(buf), "%dx%d", 1, 2);
EXPECT_STREQ("1x2", buf);
// 2-byte character.
snprintf(buf, sizeof(buf), "%d\xc2\xa2%d", 1, 2);
EXPECT_STREQ("1¢2", buf);
// 3-byte character.
snprintf(buf, sizeof(buf), "%d\xe2\x82\xac%d", 1, 2);
EXPECT_STREQ("1€2", buf);
// 4-byte character.
snprintf(buf, sizeof(buf), "%d\xf0\xa4\xad\xa2%d", 1, 2);
EXPECT_STREQ("1𤭢2", buf);
}
TEST(stdio, fprintf_failures_7229520) {
// http://b/7229520
FILE* fp;
// Unbuffered case where the fprintf(3) itself fails.