generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix libc logging implementation.

Browse Source 
The file descriptor wasn't getting set, so the writev() call was
silently failing.

There's a parallel implementation over in system/core/liblog, but it's
still using the old approach and didn't have this problem.
This commit is contained in:
Andy McFadden 2009-11-30 17:09:45 -08:00
parent 3bbac05726
commit 5cdb2b73d2
1 changed files with 2 additions and 1 deletions

3
libc/bionic/logd_write.c

@ -66,7 +66,7 @@ static int __write_to_log_null(log_id_t log_id, struct iovec *vec);
static pthread_mutex_t log_init_lock = PTHREAD_MUTEX_INITIALIZER; static pthread_mutex_t log_init_lock = PTHREAD_MUTEX_INITIALIZER;
log_channel_t log_channels[LOG_ID_MAX] = { static log_channel_t log_channels[LOG_ID_MAX] = {
{ __write_to_log_null, -1, NULL }, { __write_to_log_null, -1, NULL },
{ __write_to_log_init, -1, "/dev/"LOGGER_LOG_MAIN }, { __write_to_log_init, -1, "/dev/"LOGGER_LOG_MAIN },
{ __write_to_log_init, -1, "/dev/"LOGGER_LOG_RADIO } { __write_to_log_init, -1, "/dev/"LOGGER_LOG_RADIO }
@ -112,6 +112,7 @@ static int __write_to_log_init(log_id_t log_id, struct iovec *vec)
log_channels[log_id].logger = log_channels[log_id].logger =
(fd < 0) ? __write_to_log_null : __write_to_log_kernel; (fd < 0) ? __write_to_log_null : __write_to_log_kernel;
log_channels[log_id].fd = fd;
pthread_mutex_unlock(&log_init_lock); pthread_mutex_unlock(&log_init_lock);