generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge "Change how DNS resolver handle no default iface" into klp-dev

Browse Source
This commit is contained in:
Robert Greenwalt 2013-08-24 12:20:00 +00:00 committed by Android (Google) Code Review
commit 26ac803232
2 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libc/netbsd/net/getaddrinfo.c
View File

@ -1874,10 +1874,10 @@ static bool _using_default_dns(const char *iface)
if (iface == NULL || *iface == '\0') return true; if (iface == NULL || *iface == '\0') return true;
if_len = _resolv_get_default_iface(buf, sizeof(buf)); if_len = _resolv_get_default_iface(buf, sizeof(buf));
if (if_len + 1 <= sizeof(buf)) { if (if_len != 0 && if_len + 1 <= sizeof(buf)) {
if (strcmp(buf, iface) != 0) return false; if (strcmp(buf, iface) == 0) return true;
} }
return true; return false;
} }
/*ARGSUSED*/ /*ARGSUSED*/

22
libc/netbsd/resolv/res_cache.c
View File

@ -2531,14 +2531,15 @@ _resolv_set_iface_for_uid_range(const char* ifname, int uid_start, int uid_end)
uidiface_info->next = _res_uidiface_list.next; uidiface_info->next = _res_uidiface_list.next;
_res_uidiface_list.next = uidiface_info; _res_uidiface_list.next = uidiface_info;
XLOG("_resolv_set_iface_for_uid_range: [%d,%d], iface %s\n", low, high, ifname); XLOG("_resolv_set_iface_for_uid_range: [%d,%d], iface %s\n", uid_start, uid_end,
ifname);
} else { } else {
XLOG("_resolv_set_iface_for_uid_range failing calloc\n"); XLOG("_resolv_set_iface_for_uid_range failing calloc\n");
rv = -1; rv = -1;
errno = EINVAL; errno = EINVAL;
} }
} else { } else {
XLOG("_resolv_set_iface_for_uid_range range [%d,%d] overlaps\n", low, high); XLOG("_resolv_set_iface_for_uid_range range [%d,%d] overlaps\n", uid_start, uid_end);
rv = -1; rv = -1;
errno = EINVAL; errno = EINVAL;
} }
@ -2603,19 +2604,16 @@ _resolv_get_default_iface(char* buff, size_t buffLen)
char* ifname = _get_default_iface_locked(); // never null, but may be empty char* ifname = _get_default_iface_locked(); // never null, but may be empty
// if default interface not set. Get first cache with an interface // if default interface not set give up.
if (ifname[0] == '\0') { if (ifname[0] == '\0') {
ifname = _find_any_iface_name_locked(); // may be null pthread_mutex_unlock(&_res_cache_list_lock);
return 0;
} }
size_t len = 0; size_t len = strlen(ifname);
// if we got the default iface or if (no-default) the find_any call gave an answer if (len < buffLen) {
if (ifname) { strncpy(buff, ifname, len);
len = strlen(ifname); buff[len] = '\0';
if (len < buffLen) {
strncpy(buff, ifname, len);
buff[len] = '\0';
}
} else { } else {
buff[0] = '\0'; buff[0] = '\0';
} }