generic-library/ChaiScript
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Catch missing virtual destructors, enable g++ warnings

Browse Source
This commit is contained in:
Jason Turner 2014-03-04 11:20:45 -07:00
parent daf5480c48
commit ebbcc5cbdb
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CMakeLists.txt
View File

@ -89,7 +89,7 @@ if(MSVC)
add_definitions(/W4) add_definitions(/W4)
add_definitions(/bigobj) add_definitions(/bigobj)
else() else()
add_definitions(-Wall -Wextra -Wshadow -pedantic ${CPP11_FLAG}) add_definitions(-Wall -Wextra -Wshadow -Wnon-virtual-dtor -pedantic ${CPP11_FLAG})
if (APPLE) if (APPLE)
add_definitions(-Wno-sign-compare) add_definitions(-Wno-sign-compare)

7
include/chaiscript/dispatchkit/any.hpp
View File

@ -42,6 +42,7 @@ namespace chaiscript {
private: private:
struct Data struct Data
{ {
virtual ~Data() {}
virtual void *data() = 0; virtual void *data() = 0;
virtual const std::type_info &type() const = 0; virtual const std::type_info &type() const = 0;
virtual std::shared_ptr<Data> clone() const = 0; virtual std::shared_ptr<Data> clone() const = 0;
@ -56,6 +57,8 @@ namespace chaiscript {
{ {
} }
virtual ~Data_Impl() {}
virtual void *data() virtual void *data()
{ {
return &m_data; return &m_data;
@ -94,9 +97,9 @@ namespace chaiscript {
} }
template<typename ValueType> template<typename ValueType>
Any(const ValueType &t_value) Any(const ValueType &t_value)
: m_data(std::shared_ptr<Data>(new Data_Impl<ValueType>(t_value)))
{ {
m_data = std::shared_ptr<Data>(new Data_Impl<ValueType>(t_value));
} }
Any & operator=(const Any &t_any) Any & operator=(const Any &t_any)

6
include/chaiscript/dispatchkit/proxy_functions.hpp
View File

@ -39,6 +39,7 @@ namespace chaiscript
{ {
public: public:
virtual ~Proxy_Function_Base() {} virtual ~Proxy_Function_Base() {}
Boxed_Value operator()(const std::vector<Boxed_Value> &params, const chaiscript::Dynamic_Cast_Conversions &t_conversions) const Boxed_Value operator()(const std::vector<Boxed_Value> &params, const chaiscript::Dynamic_Cast_Conversions &t_conversions) const
{ {
Boxed_Value bv = do_call(params, t_conversions); Boxed_Value bv = do_call(params, t_conversions);
@ -205,6 +206,8 @@ namespace chaiscript
{ {
} }
virtual ~Dynamic_Proxy_Function() {}
virtual bool operator==(const Proxy_Function_Base &rhs) const virtual bool operator==(const Proxy_Function_Base &rhs) const
{ {
const Dynamic_Proxy_Function *prhs = dynamic_cast<const Dynamic_Proxy_Function *>(&rhs); const Dynamic_Proxy_Function *prhs = dynamic_cast<const Dynamic_Proxy_Function *>(&rhs);
@ -221,9 +224,6 @@ namespace chaiscript
&& test_guard(vals, t_conversions); && test_guard(vals, t_conversions);
} }
virtual ~Dynamic_Proxy_Function() {}
virtual int get_arity() const virtual int get_arity() const
{ {
return m_arity; return m_arity;