From 6eab8ddfe154a4ebbe956a5165b390ee700fae1b Mon Sep 17 00:00:00 2001 From: Jason Turner Date: Sat, 10 May 2014 08:25:38 -0600 Subject: [PATCH] Apply changes applied from clang-modernize Needed 1-2 cleanups by hand. 99% was automatic. * The version that ships with ubuntu 14.04 seems to not work. I had to build from scratch * Use cmake to generate the build commands that clang-modernize wants ```sh cmake -DCMAKE_EXPORT_COMPILE_COMMANDS:bool=true ../ChaiScript/ ``` * Use the clang-modernize tool. Note that you have to be pretty explicit about the include paths if you want it to also update your include files ```sh ../llvm-build/bin/clang-modernize ../ChaiScript/src/*.cpp -for-compilers=gcc-4.8 -include /home/jason/ChaiScript/include,/hjason/ChaiScript/include/chaiscript,/home/jason/ChaiScript/include/chaiscript/dispatchkit,/home/jason/ChaiScript/include/chaiscript/language -p compile_commands.json ``` * In my case, it left some unused `typedef`s behind, which I cleaned up. --- include/chaiscript/dispatchkit/any.hpp | 14 ++- .../chaiscript/dispatchkit/bad_boxed_cast.hpp | 10 +- .../chaiscript/dispatchkit/bootstrap_stl.hpp | 8 +- .../chaiscript/dispatchkit/boxed_value.hpp | 4 +- .../chaiscript/dispatchkit/dispatchkit.hpp | 60 ++++------ .../dispatchkit/dynamic_cast_conversion.hpp | 12 +- .../chaiscript/dispatchkit/dynamic_object.hpp | 46 ++++---- .../dispatchkit/exception_specification.hpp | 10 +- .../chaiscript/dispatchkit/function_call.hpp | 2 +- .../dispatchkit/function_call_detail.hpp | 4 +- .../dispatchkit/proxy_constructors.hpp | 2 +- .../dispatchkit/proxy_functions.hpp | 76 ++++++------ include/chaiscript/dispatchkit/type_info.hpp | 8 +- .../chaiscript/language/chaiscript_common.hpp | 24 ++-- .../chaiscript/language/chaiscript_engine.hpp | 20 ++-- .../chaiscript/language/chaiscript_eval.hpp | 108 +++++++++--------- .../chaiscript/language/chaiscript_parser.hpp | 12 +- src/main.cpp | 2 +- src/test_module.cpp | 2 +- 19 files changed, 207 insertions(+), 217 deletions(-) diff --git a/include/chaiscript/dispatchkit/any.hpp b/include/chaiscript/dispatchkit/any.hpp index 75a01c0..2d69b67 100644 --- a/include/chaiscript/dispatchkit/any.hpp +++ b/include/chaiscript/dispatchkit/any.hpp @@ -7,6 +7,8 @@ #ifndef CHAISCRIPT_ANY_HPP_ #define CHAISCRIPT_ANY_HPP_ +#include + namespace chaiscript { namespace detail { namespace exception @@ -27,7 +29,7 @@ namespace chaiscript { virtual ~bad_any_cast() CHAISCRIPT_NOEXCEPT {} /// \brief Description of what error occured - virtual const char * what() const CHAISCRIPT_NOEXCEPT + virtual const char * what() const CHAISCRIPT_NOEXCEPT override { return m_what.c_str(); } @@ -51,25 +53,25 @@ namespace chaiscript { template struct Data_Impl : Data { - Data_Impl(const T &t_type) + Data_Impl(T t_type) : m_type(typeid(T)), - m_data(t_type) + m_data(std::move(t_type)) { } virtual ~Data_Impl() {} - virtual void *data() + virtual void *data() override { return &m_data; } - const std::type_info &type() const + const std::type_info &type() const override { return m_type; } - std::shared_ptr clone() const + std::shared_ptr clone() const override { return std::shared_ptr(new Data_Impl(m_data)); } diff --git a/include/chaiscript/dispatchkit/bad_boxed_cast.hpp b/include/chaiscript/dispatchkit/bad_boxed_cast.hpp index 0d5fb7e..e2037a6 100644 --- a/include/chaiscript/dispatchkit/bad_boxed_cast.hpp +++ b/include/chaiscript/dispatchkit/bad_boxed_cast.hpp @@ -22,8 +22,8 @@ namespace chaiscript { public: bad_boxed_cast(const Type_Info &t_from, const std::type_info &t_to, - const std::string &t_what) CHAISCRIPT_NOEXCEPT - : from(t_from), to(&t_to), m_what(t_what) + std::string t_what) CHAISCRIPT_NOEXCEPT + : from(t_from), to(&t_to), m_what(std::move(t_what)) { } @@ -32,15 +32,15 @@ namespace chaiscript { } - bad_boxed_cast(const std::string &t_what) CHAISCRIPT_NOEXCEPT - : to(0), m_what(t_what) + bad_boxed_cast(std::string t_what) CHAISCRIPT_NOEXCEPT + : to(nullptr), m_what(std::move(t_what)) { } virtual ~bad_boxed_cast() CHAISCRIPT_NOEXCEPT {} /// \brief Description of what error occured - virtual const char * what() const CHAISCRIPT_NOEXCEPT + virtual const char * what() const CHAISCRIPT_NOEXCEPT override { return m_what.c_str(); } diff --git a/include/chaiscript/dispatchkit/bootstrap_stl.hpp b/include/chaiscript/dispatchkit/bootstrap_stl.hpp index 13b778a..af15e12 100644 --- a/include/chaiscript/dispatchkit/bootstrap_stl.hpp +++ b/include/chaiscript/dispatchkit/bootstrap_stl.hpp @@ -189,8 +189,8 @@ namespace chaiscript template void insert_at(Type &container, int pos, const typename Type::value_type &v) { - typename Type::iterator itr = container.begin(); - typename Type::iterator end = container.end(); + auto itr = container.begin(); + auto end = container.end(); if (pos < 0 || std::distance(itr, end) < pos) { @@ -206,8 +206,8 @@ namespace chaiscript template void erase_at(Type &container, int pos) { - typename Type::iterator itr = container.begin(); - typename Type::iterator end = container.end(); + auto itr = container.begin(); + auto end = container.end(); if (pos < 0 || std::distance(itr, end) < (pos-1)) { diff --git a/include/chaiscript/dispatchkit/boxed_value.hpp b/include/chaiscript/dispatchkit/boxed_value.hpp index 98bbde3..ee405e4 100644 --- a/include/chaiscript/dispatchkit/boxed_value.hpp +++ b/include/chaiscript/dispatchkit/boxed_value.hpp @@ -36,7 +36,7 @@ namespace chaiscript const chaiscript::detail::Any &to, bool tr, const void *t_void_ptr) - : m_type_info(ti), m_obj(to), m_data_ptr(ti.is_const()?0:const_cast(t_void_ptr)), m_const_data_ptr(t_void_ptr), + : m_type_info(ti), m_obj(to), m_data_ptr(ti.is_const()?nullptr:const_cast(t_void_ptr)), m_const_data_ptr(t_void_ptr), m_is_ref(tr) { } @@ -201,7 +201,7 @@ namespace chaiscript bool is_null() const { - return (m_data->m_data_ptr == 0 && m_data->m_const_data_ptr == 0); + return (m_data->m_data_ptr == nullptr && m_data->m_const_data_ptr == nullptr); } const chaiscript::detail::Any & get() const diff --git a/include/chaiscript/dispatchkit/dispatchkit.hpp b/include/chaiscript/dispatchkit/dispatchkit.hpp index 610055d..9cbf01b 100644 --- a/include/chaiscript/dispatchkit/dispatchkit.hpp +++ b/include/chaiscript/dispatchkit/dispatchkit.hpp @@ -252,7 +252,7 @@ namespace chaiscript { } - virtual bool operator==(const dispatch::Proxy_Function_Base &rhs) const + virtual bool operator==(const dispatch::Proxy_Function_Base &rhs) const override { try { const Dispatch_Function &dispatchfun = dynamic_cast(rhs); @@ -264,17 +264,17 @@ namespace chaiscript virtual ~Dispatch_Function() {} - virtual std::vector get_contained_functions() const + virtual std::vector get_contained_functions() const override { return std::vector(m_funcs.begin(), m_funcs.end()); } - virtual int get_arity() const + virtual int get_arity() const override { typedef std::vector function_vec; - function_vec::const_iterator begin = m_funcs.begin(); + auto begin = m_funcs.begin(); const function_vec::const_iterator end = m_funcs.end(); if (begin != end) @@ -300,12 +300,10 @@ namespace chaiscript return -1; // unknown arity } - virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const + virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const override { - typedef std::vector function_vec; - - function_vec::const_iterator begin = m_funcs.begin(); - function_vec::const_iterator end = m_funcs.end(); + auto begin = m_funcs.begin(); + auto end = m_funcs.end(); while (begin != end) { @@ -320,13 +318,13 @@ namespace chaiscript return false; } - virtual std::string annotation() const + virtual std::string annotation() const override { return "Multiple method dispatch function wrapper."; } protected: - virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const + virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const override { return dispatch::dispatch(m_funcs.begin(), m_funcs.end(), params, t_conversions); } @@ -338,7 +336,7 @@ namespace chaiscript { typedef std::vector function_vec; - function_vec::const_iterator begin = t_funcs.begin(); + auto begin = t_funcs.begin(); const function_vec::const_iterator end = t_funcs.end(); if (begin != end) @@ -477,7 +475,7 @@ namespace chaiscript validate_object_name(name); Scope &scope = stack.back(); - Scope::iterator itr = scope.find(name); + auto itr = scope.find(name); if (itr != stack.back().end()) { throw chaiscript::exception::name_conflict_error(name); @@ -598,7 +596,7 @@ namespace chaiscript { chaiscript::detail::threading::shared_lock l(m_global_object_mutex); - std::map::const_iterator itr = m_state.m_global_objects.find(name); + auto itr = m_state.m_global_objects.find(name); if (itr != m_state.m_global_objects.end()) { return itr->second; @@ -628,7 +626,7 @@ namespace chaiscript { chaiscript::detail::threading::shared_lock l(m_mutex); - Type_Name_Map::const_iterator itr = m_state.m_types.find(name); + auto itr = m_state.m_types.find(name); if (itr != m_state.m_types.end()) { @@ -647,13 +645,11 @@ namespace chaiscript { chaiscript::detail::threading::shared_lock l(m_mutex); - for (Type_Name_Map::const_iterator itr = m_state.m_types.begin(); - itr != m_state.m_types.end(); - ++itr) + for (const auto & elem : m_state.m_types) { - if (itr->second.bare_equal(ti)) + if (elem.second.bare_equal(ti)) { - return itr->first; + return elem.first; } } @@ -680,7 +676,7 @@ namespace chaiscript const std::map > &funs = get_functions_int(); - std::map >::const_iterator itr + auto itr = funs.find(t_name); if (itr != funs.end()) @@ -699,7 +695,7 @@ namespace chaiscript const std::map &funs = get_function_objects_int(); - std::map::const_iterator itr = funs.find(t_name); + auto itr = funs.find(t_name); if (itr != funs.end()) { @@ -756,7 +752,7 @@ namespace chaiscript // note: map insert doesn't overwrite existing values, which is why this works - for (StackData::reverse_iterator itr = stack.rbegin(); itr != stack.rend(); ++itr) + for (auto itr = stack.rbegin(); itr != stack.rend(); ++itr) { retval.insert(itr->begin(), itr->end()); } @@ -783,11 +779,9 @@ namespace chaiscript std::map objs; - for (std::map::const_iterator itr = funs.begin(); - itr != funs.end(); - ++itr) + for (const auto & fun : funs) { - objs.insert(std::make_pair(itr->first, const_var(itr->second))); + objs.insert(std::make_pair(fun.first, const_var(fun.second))); } return objs; @@ -805,15 +799,11 @@ namespace chaiscript const std::map > &functions = get_functions_int(); - for (std::map >::const_iterator itr = functions.begin(); - itr != functions.end(); - ++itr) + for (const auto & function : functions) { - for (std::vector::const_iterator itr2 = itr->second.begin(); - itr2 != itr->second.end(); - ++itr2) + for (const auto & internal_func : function.second) { - rets.push_back(std::make_pair(itr->first, *itr2)); + rets.push_back(std::make_pair(function.first, internal_func)); } } @@ -1171,7 +1161,7 @@ namespace chaiscript std::map > &funcs = get_functions_int(); - std::map >::iterator itr + auto itr = funcs.find(t_name); std::map &func_objs = get_function_objects_int(); diff --git a/include/chaiscript/dispatchkit/dynamic_cast_conversion.hpp b/include/chaiscript/dispatchkit/dynamic_cast_conversion.hpp index ac6f947..5f2d3af 100644 --- a/include/chaiscript/dispatchkit/dynamic_cast_conversion.hpp +++ b/include/chaiscript/dispatchkit/dynamic_cast_conversion.hpp @@ -109,11 +109,11 @@ namespace chaiscript // Pull the reference out of the contained boxed value, which we know is the type we want if (t_from.is_const()) { - const From &d = detail::Cast_Helper::cast(t_from, 0); + const From &d = detail::Cast_Helper::cast(t_from, nullptr); const To &data = dynamic_cast(d); return Boxed_Value(std::cref(data)); } else { - From &d = detail::Cast_Helper::cast(t_from, 0); + From &d = detail::Cast_Helper::cast(t_from, nullptr); To &data = dynamic_cast(d); return Boxed_Value(std::ref(data)); } @@ -133,12 +133,12 @@ namespace chaiscript { } - virtual Boxed_Value convert_down(const Boxed_Value &t_base) const + virtual Boxed_Value convert_down(const Boxed_Value &t_base) const override { return Dynamic_Caster::cast(t_base); } - virtual Boxed_Value convert(const Boxed_Value &t_derived) const + virtual Boxed_Value convert(const Boxed_Value &t_derived) const override { return Dynamic_Caster::cast(t_derived); } @@ -209,7 +209,7 @@ namespace chaiscript { chaiscript::detail::threading::shared_lock l(m_mutex); - std::set >::const_iterator itr = + auto itr = find(base, derived); if (itr != m_conversions.end()) @@ -224,7 +224,7 @@ namespace chaiscript std::set >::const_iterator find( const Type_Info &base, const Type_Info &derived) const { - for (std::set >::const_iterator itr = m_conversions.begin(); + for (auto itr = m_conversions.begin(); itr != m_conversions.end(); ++itr) { diff --git a/include/chaiscript/dispatchkit/dynamic_object.hpp b/include/chaiscript/dispatchkit/dynamic_object.hpp index e06afe4..202004f 100644 --- a/include/chaiscript/dispatchkit/dynamic_object.hpp +++ b/include/chaiscript/dispatchkit/dynamic_object.hpp @@ -7,6 +7,8 @@ #ifndef CHAISCRIPT_DYNAMIC_OBJECT_HPP_ #define CHAISCRIPT_DYNAMIC_OBJECT_HPP_ +#include + namespace chaiscript { @@ -15,8 +17,8 @@ namespace chaiscript class Dynamic_Object { public: - Dynamic_Object(const std::string &t_type_name) - : m_type_name(t_type_name) + Dynamic_Object(std::string t_type_name) + : m_type_name(std::move(t_type_name)) { } @@ -52,21 +54,21 @@ namespace chaiscript { public: Dynamic_Object_Function( - const std::string &t_type_name, + std::string t_type_name, const Proxy_Function &t_func) : Proxy_Function_Base(t_func->get_param_types()), - m_type_name(t_type_name), m_func(t_func), m_doti(user_type()) + m_type_name(std::move(t_type_name)), m_func(t_func), m_doti(user_type()) { assert( (t_func->get_arity() > 0 || t_func->get_arity() < 0) && "Programming error, Dynamic_Object_Function must have at least one parameter (this)"); } Dynamic_Object_Function( - const std::string &t_type_name, + std::string t_type_name, const Proxy_Function &t_func, const Type_Info &t_ti) : Proxy_Function_Base(build_param_types(t_func->get_param_types(), t_ti)), - m_type_name(t_type_name), m_func(t_func), m_ti(new Type_Info(t_ti)), m_doti(user_type()) + m_type_name(std::move(t_type_name)), m_func(t_func), m_ti(new Type_Info(t_ti)), m_doti(user_type()) { assert( (t_func->get_arity() > 0 || t_func->get_arity() < 0) && "Programming error, Dynamic_Object_Function must have at least one parameter (this)"); @@ -76,7 +78,7 @@ namespace chaiscript Dynamic_Object_Function &operator=(const Dynamic_Object_Function) = delete; - virtual bool operator==(const Proxy_Function_Base &f) const + virtual bool operator==(const Proxy_Function_Base &f) const override { const Dynamic_Object_Function *df = dynamic_cast(&f); if (df) @@ -87,7 +89,7 @@ namespace chaiscript } } - virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const + virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const override { if (dynamic_object_typename_match(vals, m_type_name, m_ti, t_conversions)) { @@ -97,25 +99,25 @@ namespace chaiscript } } - virtual std::vector get_contained_functions() const + virtual std::vector get_contained_functions() const override { return {m_func}; } - virtual int get_arity() const + virtual int get_arity() const override { return m_func->get_arity(); } - virtual std::string annotation() const + virtual std::string annotation() const override { return m_func->annotation(); } protected: - virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const + virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const override { if (dynamic_object_typename_match(params, m_type_name, m_ti, t_conversions)) { @@ -125,7 +127,7 @@ namespace chaiscript } } - virtual bool compare_first_type(const Boxed_Value &bv, const Dynamic_Cast_Conversions &t_conversions) const + virtual bool compare_first_type(const Boxed_Value &bv, const Dynamic_Cast_Conversions &t_conversions) const override { return dynamic_object_typename_match(bv, m_type_name, m_ti, t_conversions); } @@ -194,10 +196,10 @@ namespace chaiscript { public: Dynamic_Object_Constructor( - const std::string &t_type_name, + std::string t_type_name, const Proxy_Function &t_func) : Proxy_Function_Base(build_type_list(t_func->get_param_types())), - m_type_name(t_type_name), m_func(t_func) + m_type_name(std::move(t_type_name)), m_func(t_func) { assert( (t_func->get_arity() > 0 || t_func->get_arity() < 0) && "Programming error, Dynamic_Object_Function must have at least one parameter (this)"); @@ -205,8 +207,8 @@ namespace chaiscript static std::vector build_type_list(const std::vector &tl) { - std::vector::const_iterator begin = tl.begin(); - std::vector::const_iterator end = tl.end(); + auto begin = tl.begin(); + auto end = tl.end(); if (begin != end) { @@ -218,7 +220,7 @@ namespace chaiscript virtual ~Dynamic_Object_Constructor() {} - virtual bool operator==(const Proxy_Function_Base &f) const + virtual bool operator==(const Proxy_Function_Base &f) const override { const Dynamic_Object_Constructor *dc = dynamic_cast(&f); if (dc) @@ -229,7 +231,7 @@ namespace chaiscript } } - virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const + virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const override { std::vector new_vals; new_vals.push_back(Boxed_Value(Dynamic_Object(m_type_name))); @@ -239,19 +241,19 @@ namespace chaiscript } - virtual int get_arity() const + virtual int get_arity() const override { // "this" is not considered part of the arity return m_func->get_arity() - 1; } - virtual std::string annotation() const + virtual std::string annotation() const override { return m_func->annotation(); } protected: - virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const + virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const override { std::vector new_params; chaiscript::Boxed_Value bv = var(Dynamic_Object(m_type_name)); diff --git a/include/chaiscript/dispatchkit/exception_specification.hpp b/include/chaiscript/dispatchkit/exception_specification.hpp index 1997ef0..0c9ae94 100644 --- a/include/chaiscript/dispatchkit/exception_specification.hpp +++ b/include/chaiscript/dispatchkit/exception_specification.hpp @@ -32,7 +32,7 @@ namespace chaiscript { virtual ~Exception_Handler_Impl1() {} - virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine) + virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine) override { throw_type(bv, t_engine); } @@ -42,7 +42,7 @@ namespace chaiscript { virtual ~Exception_Handler_Impl2() {} - virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine) + virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine) override { throw_type(bv, t_engine); throw_type(bv, t_engine); @@ -54,7 +54,7 @@ namespace chaiscript { virtual ~Exception_Handler_Impl3() {} - virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine) + virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine) override { throw_type(bv, t_engine); throw_type(bv, t_engine); @@ -66,7 +66,7 @@ namespace chaiscript { virtual ~Exception_Handler_Impl4() {} - virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine) + virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine) override { throw_type(bv, t_engine); throw_type(bv, t_engine); @@ -79,7 +79,7 @@ namespace chaiscript { virtual ~Exception_Handler_Impl5() {} - virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine) + virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine) override { throw_type(bv, t_engine); throw_type(bv, t_engine); diff --git a/include/chaiscript/dispatchkit/function_call.hpp b/include/chaiscript/dispatchkit/function_call.hpp index 1ef1ca4..24b99e3 100644 --- a/include/chaiscript/dispatchkit/function_call.hpp +++ b/include/chaiscript/dispatchkit/function_call.hpp @@ -31,7 +31,7 @@ namespace chaiscript std::function functor(const std::vector &funcs, const Dynamic_Cast_Conversions *t_conversions) { - FunctionType *p=0; + FunctionType *p=nullptr; return detail::build_function_caller_helper(p, funcs, t_conversions); } diff --git a/include/chaiscript/dispatchkit/function_call_detail.hpp b/include/chaiscript/dispatchkit/function_call_detail.hpp index 40cfe86..484e693 100644 --- a/include/chaiscript/dispatchkit/function_call_detail.hpp +++ b/include/chaiscript/dispatchkit/function_call_detail.hpp @@ -64,8 +64,8 @@ namespace chaiscript template struct Build_Function_Caller_Helper { - Build_Function_Caller_Helper(const std::vector &t_funcs, const Dynamic_Cast_Conversions &t_conversions) - : m_funcs(t_funcs), + Build_Function_Caller_Helper(std::vector t_funcs, const Dynamic_Cast_Conversions &t_conversions) + : m_funcs(std::move(t_funcs)), m_conversions(t_conversions) { } diff --git a/include/chaiscript/dispatchkit/proxy_constructors.hpp b/include/chaiscript/dispatchkit/proxy_constructors.hpp index 1fe2f3f..0c56f95 100644 --- a/include/chaiscript/dispatchkit/proxy_constructors.hpp +++ b/include/chaiscript/dispatchkit/proxy_constructors.hpp @@ -48,7 +48,7 @@ namespace chaiscript template Proxy_Function constructor() { - T *f = 0; + T *f = nullptr; return (dispatch::detail::build_constructor_(f)); } diff --git a/include/chaiscript/dispatchkit/proxy_functions.hpp b/include/chaiscript/dispatchkit/proxy_functions.hpp index f2e5767..fd2ace0 100644 --- a/include/chaiscript/dispatchkit/proxy_functions.hpp +++ b/include/chaiscript/dispatchkit/proxy_functions.hpp @@ -112,8 +112,8 @@ namespace chaiscript protected: virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const = 0; - Proxy_Function_Base(const std::vector &t_types) - : m_types(t_types), m_has_arithmetic_param(false) + Proxy_Function_Base(std::vector t_types) + : m_types(std::move(t_types)), m_has_arithmetic_param(false) { for (size_t i = 1; i < m_types.size(); ++i) { @@ -196,19 +196,19 @@ namespace chaiscript { public: Dynamic_Proxy_Function( - const std::function &)> &t_f, + std::function &)> t_f, int t_arity=-1, - const AST_NodePtr &t_parsenode = AST_NodePtr(), - const std::string &t_description = "", - const Proxy_Function &t_guard = Proxy_Function()) + AST_NodePtr t_parsenode = AST_NodePtr(), + std::string t_description = "", + Proxy_Function t_guard = Proxy_Function()) : Proxy_Function_Base(build_param_type_list(t_arity)), - m_f(t_f), m_arity(t_arity), m_description(t_description), m_guard(t_guard), m_parsenode(t_parsenode) + m_f(std::move(t_f)), m_arity(t_arity), m_description(std::move(t_description)), m_guard(std::move(t_guard)), m_parsenode(std::move(t_parsenode)) { } virtual ~Dynamic_Proxy_Function() {} - virtual bool operator==(const Proxy_Function_Base &rhs) const + virtual bool operator==(const Proxy_Function_Base &rhs) const override { const Dynamic_Proxy_Function *prhs = dynamic_cast(&rhs); @@ -218,13 +218,13 @@ namespace chaiscript && !this->m_guard && !prhs->m_guard); } - virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const + virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const override { return (m_arity < 0 || vals.size() == size_t(m_arity)) && test_guard(vals, t_conversions); } - virtual int get_arity() const + virtual int get_arity() const override { return m_arity; } @@ -239,13 +239,13 @@ namespace chaiscript return m_parsenode; } - virtual std::string annotation() const + virtual std::string annotation() const override { return m_description; } protected: - virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const + virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const override { if (m_arity < 0 || params.size() == size_t(m_arity)) { @@ -329,19 +329,19 @@ namespace chaiscript assert(m_f->get_arity() < 0 || m_f->get_arity() == static_cast(m_args.size())); } - virtual bool operator==(const Proxy_Function_Base &t_f) const + virtual bool operator==(const Proxy_Function_Base &t_f) const override { return &t_f == this; } virtual ~Bound_Function() {} - virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const + virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const override { return m_f->call_match(build_param_list(vals), t_conversions); } - virtual std::vector get_contained_functions() const + virtual std::vector get_contained_functions() const override { std::vector fs; fs.push_back(m_f); @@ -351,10 +351,8 @@ namespace chaiscript std::vector build_param_list(const std::vector ¶ms) const { - typedef std::vector::const_iterator pitr; - - pitr parg = params.begin(); - pitr barg = m_args.begin(); + auto parg = params.begin(); + auto barg = m_args.begin(); std::vector args; @@ -382,12 +380,12 @@ namespace chaiscript return args; } - virtual int get_arity() const + virtual int get_arity() const override { return m_arity; } - virtual std::string annotation() const + virtual std::string annotation() const override { return "Bound: " + m_f->annotation(); } @@ -416,7 +414,7 @@ namespace chaiscript return retval; } - virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const + virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const override { return (*m_f)(build_param_list(params), t_conversions); } @@ -436,26 +434,26 @@ namespace chaiscript class Proxy_Function_Impl : public Proxy_Function_Base { public: - Proxy_Function_Impl(const std::function &f) - : Proxy_Function_Base(detail::build_param_type_list(static_cast(0))), - m_f(f), m_dummy_func(0) + Proxy_Function_Impl(std::function f) + : Proxy_Function_Base(detail::build_param_type_list(static_cast(nullptr))), + m_f(std::move(f)), m_dummy_func(nullptr) { } virtual ~Proxy_Function_Impl() {} - virtual bool operator==(const Proxy_Function_Base &t_func) const + virtual bool operator==(const Proxy_Function_Base &t_func) const override { const Proxy_Function_Impl *pimpl = dynamic_cast *>(&t_func); - return pimpl != 0; + return pimpl != nullptr; } - virtual int get_arity() const + virtual int get_arity() const override { return static_cast(m_types.size()) - 1; } - virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const + virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &t_conversions) const override { if (int(vals.size()) != get_arity()) { @@ -465,7 +463,7 @@ namespace chaiscript return compare_types(m_types, vals) || detail::compare_types_cast(m_dummy_func, vals, t_conversions); } - virtual std::string annotation() const + virtual std::string annotation() const override { return ""; } @@ -476,7 +474,7 @@ namespace chaiscript } protected: - virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const + virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const override { return detail::Do_Call::result_type>::go(m_f, params, t_conversions); } @@ -501,7 +499,7 @@ namespace chaiscript virtual ~Attribute_Access() {} - virtual bool operator==(const Proxy_Function_Base &t_func) const + virtual bool operator==(const Proxy_Function_Base &t_func) const override { const Attribute_Access * aa = dynamic_cast *>(&t_func); @@ -514,12 +512,12 @@ namespace chaiscript } - virtual int get_arity() const + virtual int get_arity() const override { return 1; } - virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &) const + virtual bool call_match(const std::vector &vals, const Dynamic_Cast_Conversions &) const override { if (vals.size() != 1) { @@ -529,13 +527,13 @@ namespace chaiscript return vals[0].get_type_info().bare_equal(user_type()); } - virtual std::string annotation() const + virtual std::string annotation() const override { return ""; } protected: - virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const + virtual Boxed_Value do_call(const std::vector ¶ms, const Dynamic_Cast_Conversions &t_conversions) const override { if (params.size() == 1) { @@ -573,9 +571,9 @@ namespace chaiscript class dispatch_error : public std::runtime_error { public: - dispatch_error(const std::vector &t_parameters, - const std::vector &t_functions) - : std::runtime_error("Error with function dispatch"), parameters(t_parameters), functions(t_functions) + dispatch_error(std::vector t_parameters, + std::vector t_functions) + : std::runtime_error("Error with function dispatch"), parameters(std::move(t_parameters)), functions(std::move(t_functions)) { } diff --git a/include/chaiscript/dispatchkit/type_info.hpp b/include/chaiscript/dispatchkit/type_info.hpp index fe4c742..aef7a18 100644 --- a/include/chaiscript/dispatchkit/type_info.hpp +++ b/include/chaiscript/dispatchkit/type_info.hpp @@ -38,7 +38,7 @@ namespace chaiscript } Type_Info() - : m_type_info(0), m_bare_type_info(0), + : m_type_info(nullptr), m_bare_type_info(nullptr), m_is_const(false), m_is_reference(false), m_is_pointer(false), m_is_void(false), m_is_arithmetic(false), m_is_undef(true) @@ -81,7 +81,7 @@ namespace chaiscript bool operator==(const std::type_info &ti) const { - return m_type_info != 0 && (*m_type_info) == ti; + return m_type_info != nullptr && (*m_type_info) == ti; } bool bare_equal(const Type_Info &ti) const @@ -92,7 +92,7 @@ namespace chaiscript bool bare_equal_type_info(const std::type_info &ti) const { - return m_bare_type_info != 0 + return m_bare_type_info != nullptr && (*m_bare_type_info) == ti; } @@ -100,7 +100,7 @@ namespace chaiscript bool is_reference() const { return m_is_reference; } bool is_void() const { return m_is_void; } bool is_arithmetic() const { return m_is_arithmetic; } - bool is_undef() const { return m_is_undef || m_bare_type_info == 0; } + bool is_undef() const { return m_is_undef || m_bare_type_info == nullptr; } bool is_pointer() const { return m_is_pointer; } std::string name() const diff --git a/include/chaiscript/language/chaiscript_common.hpp b/include/chaiscript/language/chaiscript_common.hpp index a628d9b..e7689c2 100644 --- a/include/chaiscript/language/chaiscript_common.hpp +++ b/include/chaiscript/language/chaiscript_common.hpp @@ -253,11 +253,9 @@ namespace chaiscript } else { ss << " " << t_functions.size() << " overloads available:" << std::endl; - for (std::vector::const_iterator itr = t_functions.begin(); - itr != t_functions.end(); - ++itr) + for (const auto & t_function : t_functions) { - ss << " " << format_types((*itr), t_dot_notation, t_ss) << std::endl; + ss << " " << format_types((t_function), t_dot_notation, t_ss) << std::endl; } } @@ -277,7 +275,7 @@ namespace chaiscript { std::string paramstr; - for (std::vector::const_iterator itr = t_parameters.begin(); + for (auto itr = t_parameters.begin(); itr != t_parameters.end(); ++itr) { @@ -404,8 +402,8 @@ namespace chaiscript oss << text; - for (unsigned int j = 0; j < this->children.size(); ++j) { - oss << this->children[j]->pretty_print(); + for (auto & elem : this->children) { + oss << elem->pretty_print(); } return oss.str(); @@ -419,8 +417,8 @@ namespace chaiscript oss << t_prepend << "(" << ast_node_type_to_string(this->identifier) << ") " << this->text << " : " << this->start.line << ", " << this->start.column << std::endl; - for (unsigned int j = 0; j < this->children.size(); ++j) { - oss << this->children[j]->to_string(t_prepend + " "); + for (auto & elem : this->children) { + oss << elem->to_string(t_prepend + " "); } return oss.str(); } @@ -446,15 +444,15 @@ namespace chaiscript } protected: - AST_Node(const std::string &t_ast_node_text, int t_id, const std::shared_ptr &t_fname, + AST_Node(std::string t_ast_node_text, int t_id, const std::shared_ptr &t_fname, int t_start_line, int t_start_col, int t_end_line, int t_end_col) : - text(t_ast_node_text), identifier(t_id), filename(t_fname), + text(std::move(t_ast_node_text)), identifier(t_id), filename(t_fname), start(t_start_line, t_start_col), end(t_end_line, t_end_col) { } - AST_Node(const std::string &t_ast_node_text, int t_id, const std::shared_ptr &t_fname) : - text(t_ast_node_text), identifier(t_id), filename(t_fname) {} + AST_Node(std::string t_ast_node_text, int t_id, const std::shared_ptr &t_fname) : + text(std::move(t_ast_node_text)), identifier(t_id), filename(t_fname) {} virtual ~AST_Node() {} diff --git a/include/chaiscript/language/chaiscript_engine.hpp b/include/chaiscript/language/chaiscript_engine.hpp index 3924ba7..ab2d075 100644 --- a/include/chaiscript/language/chaiscript_engine.hpp +++ b/include/chaiscript/language/chaiscript_engine.hpp @@ -383,9 +383,9 @@ namespace chaiscript /// \param[in] t_modulepaths Vector of paths to search when attempting to load a binary module /// \param[in] t_usepaths Vector of paths to search when attempting to "use" an included ChaiScript file ChaiScript(const ModulePtr &t_lib, - const std::vector &t_modulepaths = std::vector(), - const std::vector &t_usepaths = std::vector()) - : m_modulepaths(t_modulepaths), m_usepaths(t_usepaths) + std::vector t_modulepaths = std::vector(), + std::vector t_usepaths = std::vector()) + : m_modulepaths(std::move(t_modulepaths)), m_usepaths(std::move(t_usepaths)) { if (m_modulepaths.empty()) { @@ -407,9 +407,9 @@ namespace chaiscript /// /// \param[in] t_modulepaths Vector of paths to search when attempting to load a binary module /// \param[in] t_usepaths Vector of paths to search when attempting to "use" an included ChaiScript file - ChaiScript( const std::vector &t_modulepaths = std::vector(), - const std::vector &t_usepaths = std::vector()) - : m_modulepaths(t_modulepaths), m_usepaths(t_usepaths) + ChaiScript( std::vector t_modulepaths = std::vector(), + std::vector t_usepaths = std::vector()) + : m_modulepaths(std::move(t_modulepaths)), m_usepaths(std::move(t_usepaths)) { if (m_modulepaths.empty()) { @@ -694,14 +694,14 @@ namespace chaiscript postfixes.push_back(".so"); postfixes.push_back(""); - for (size_t i = 0; i < m_modulepaths.size(); ++i) + for (auto & elem : m_modulepaths) { - for (size_t j = 0; j < prefixes.size(); ++j) + for (auto & prefixe : prefixes) { - for (size_t k = 0; k < postfixes.size(); ++k) + for (auto & postfixe : postfixes) { try { - std::string name = m_modulepaths[i] + prefixes[j] + t_module_name + postfixes[k]; + std::string name = elem + prefixe + t_module_name + postfixe; // std::cerr << "trying location: " << name << std::endl; load_module(version_stripped_name, name); return name; diff --git a/include/chaiscript/language/chaiscript_eval.hpp b/include/chaiscript/language/chaiscript_eval.hpp index 076c7de..5e243d2 100644 --- a/include/chaiscript/language/chaiscript_eval.hpp +++ b/include/chaiscript/language/chaiscript_eval.hpp @@ -44,13 +44,13 @@ namespace chaiscript { } virtual ~Binary_Operator_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { return do_oper(t_ss, Operators::to_operator(children[1]->text), children[1]->text, this->children[0]->eval(t_ss), this->children[2]->eval(t_ss)); } - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { if (children.size() == 3) { @@ -108,7 +108,7 @@ namespace chaiscript AST_Node(t_ast_node_text, AST_Node_Type::Int, t_fname, t_start_line, t_start_col, t_end_line, t_end_col), m_value(t_bv) { } virtual ~Int_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &) override{ return m_value; } @@ -126,7 +126,7 @@ namespace chaiscript AST_Node(t_ast_node_text, AST_Node_Type::Float, t_fname, t_start_line, t_start_col, t_end_line, t_end_col), m_value(t_bv) { } virtual ~Float_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &) override{ return m_value; } @@ -143,7 +143,7 @@ namespace chaiscript { } virtual ~Id_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { if (!m_value.is_undef()) { return m_value; @@ -199,7 +199,7 @@ namespace chaiscript AST_Node(t_ast_node_text, AST_Node_Type::Eol, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Eol_AST_Node() {} - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { return "\n"; } @@ -210,7 +210,7 @@ namespace chaiscript Fun_Call_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Fun_Call, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Fun_Call_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ chaiscript::eval::detail::Function_Push_Pop fpp(t_ss); std::vector params; @@ -254,7 +254,7 @@ namespace chaiscript } } - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { std::ostringstream oss; @@ -279,7 +279,7 @@ namespace chaiscript Inplace_Fun_Call_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Inplace_Fun_Call, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Inplace_Fun_Call_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ std::vector params; if ((this->children.size() > 1) && (this->children[1]->identifier == AST_Node_Type::Arg_List)) { @@ -320,7 +320,7 @@ namespace chaiscript } } - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { std::ostringstream oss; for (unsigned int j = 0; j < this->children.size(); ++j) { @@ -345,7 +345,7 @@ namespace chaiscript AST_Node(t_ast_node_text, AST_Node_Type::Arg_List, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Arg_List_AST_Node() {} - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { std::ostringstream oss; for (unsigned int j = 0; j < this->children.size(); ++j) { @@ -375,7 +375,7 @@ namespace chaiscript {} virtual ~Equation_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { Boxed_Value retval = this->children.back()->eval(t_ss); @@ -443,7 +443,7 @@ namespace chaiscript Var_Decl_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Var_Decl, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Var_Decl_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ if (this->children[0]->identifier == AST_Node_Type::Reference) { return this->children[0]->eval(t_ss); @@ -463,7 +463,7 @@ namespace chaiscript } - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { return "var " + this->children[0]->text; } @@ -484,7 +484,7 @@ namespace chaiscript int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : Binary_Operator_AST_Node(t_ast_node_text, AST_Node_Type::Addition, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Addition_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { return do_oper(t_ss, Operators::sum, "+", this->children[0]->eval(t_ss), this->children[1]->eval(t_ss)); } }; @@ -496,7 +496,7 @@ namespace chaiscript int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : Binary_Operator_AST_Node(t_ast_node_text, AST_Node_Type::Subtraction, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Subtraction_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { return do_oper(t_ss, Operators::difference, "-", this->children[0]->eval(t_ss), this->children[1]->eval(t_ss)); } }; @@ -508,7 +508,7 @@ namespace chaiscript int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : Binary_Operator_AST_Node(t_ast_node_text, AST_Node_Type::Multiplication, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Multiplication_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { return do_oper(t_ss, Operators::product, "*", this->children[0]->eval(t_ss), this->children[1]->eval(t_ss)); } }; @@ -520,7 +520,7 @@ namespace chaiscript int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : Binary_Operator_AST_Node(t_ast_node_text, AST_Node_Type::Division, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Division_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { return do_oper(t_ss, Operators::quotient, "/", this->children[0]->eval(t_ss), this->children[1]->eval(t_ss)); } }; @@ -532,7 +532,7 @@ namespace chaiscript int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : Binary_Operator_AST_Node(t_ast_node_text, AST_Node_Type::Modulus, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Modulus_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { return do_oper(t_ss, Operators::remainder, "%", this->children[0]->eval(t_ss), this->children[1]->eval(t_ss)); } }; @@ -542,7 +542,7 @@ namespace chaiscript Array_Call_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Array_Call, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Array_Call_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ chaiscript::eval::detail::Function_Push_Pop fpp(t_ss); Boxed_Value retval = this->children[0]->eval(t_ss); std::vector params; @@ -569,7 +569,7 @@ namespace chaiscript return retval; } - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { std::ostringstream oss; oss << this->children[0]->pretty_print(); @@ -590,7 +590,7 @@ namespace chaiscript Dot_Access_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Dot_Access, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Dot_Access_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ Boxed_Value retval = this->children[0]->eval(t_ss); if (this->children.size() > 1) { @@ -658,11 +658,11 @@ namespace chaiscript AST_Node(t_ast_node_text, AST_Node_Type::Quoted_String, t_fname, t_start_line, t_start_col, t_end_line, t_end_col), m_value(const_var(t_ast_node_text)) { } virtual ~Quoted_String_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &) override { return m_value; } - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { return "\"" + text + "\""; } @@ -678,11 +678,11 @@ namespace chaiscript AST_Node(t_ast_node_text, AST_Node_Type::Single_Quoted_String, t_fname, t_start_line, t_start_col, t_end_line, t_end_col), m_value(const_var(char(t_ast_node_text.at(0)))) { } virtual ~Single_Quoted_String_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &) override{ return m_value; } - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { return "'" + text + "'"; } @@ -696,7 +696,7 @@ namespace chaiscript Lambda_AST_Node(const std::string &t_ast_node_text = "", int t_id = AST_Node_Type::Lambda, const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, t_id, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Lambda_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ std::vector t_param_names; size_t numparams = 0; @@ -724,7 +724,7 @@ namespace chaiscript Block_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Block, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Block_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ const size_t num_children = this->children.size(); chaiscript::eval::detail::Scope_Push_Pop spp(t_ss); @@ -753,7 +753,7 @@ namespace chaiscript Def_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Def, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Def_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ std::vector t_param_names; size_t numparams = 0; AST_NodePtr guardnode; @@ -809,7 +809,7 @@ namespace chaiscript While_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::While, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~While_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { chaiscript::eval::detail::Scope_Push_Pop spp(t_ss); try { @@ -838,7 +838,7 @@ namespace chaiscript Ternary_Cond_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::If, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Ternary_Cond_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ bool cond; try { cond = boxed_cast(this->children[0]->eval(t_ss)); @@ -861,7 +861,7 @@ namespace chaiscript If_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::If, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~If_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ bool cond; try { cond = boxed_cast(this->children[0]->eval(t_ss)); @@ -906,7 +906,7 @@ namespace chaiscript For_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::For, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~For_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ chaiscript::eval::detail::Scope_Push_Pop spp(t_ss); // initial expression @@ -945,7 +945,7 @@ namespace chaiscript Switch_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Switch, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Switch_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { Boxed_Value match_value; bool breaking = false; size_t currentCase = 1; @@ -988,7 +988,7 @@ namespace chaiscript Case_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Case, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Case_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { chaiscript::eval::detail::Scope_Push_Pop spp(t_ss); this->children[1]->eval(t_ss); @@ -1002,7 +1002,7 @@ namespace chaiscript Default_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Default, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Default_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { chaiscript::eval::detail::Scope_Push_Pop spp(t_ss); this->children[0]->eval(t_ss); @@ -1017,7 +1017,7 @@ namespace chaiscript Inline_Array_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Inline_Array, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Inline_Array_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ try { std::vector vec; if (this->children.size() > 0) { @@ -1034,7 +1034,7 @@ namespace chaiscript } - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { return "[" + AST_Node::pretty_print() + "]"; } @@ -1045,7 +1045,7 @@ namespace chaiscript Inline_Map_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Inline_Map, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Inline_Map_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ try { std::map retval; for (size_t i = 0; i < this->children[0]->children.size(); ++i) { @@ -1067,7 +1067,7 @@ namespace chaiscript Return_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Return, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Return_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ if (this->children.size() > 0) { throw detail::Return_Value(this->children[0]->eval(t_ss)); } @@ -1083,7 +1083,7 @@ namespace chaiscript File_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::File, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~File_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) { + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override { const size_t size = this->children.size(); for (size_t i = 0; i < size; ++i) { const Boxed_Value &retval = this->children[i]->eval(t_ss); @@ -1101,7 +1101,7 @@ namespace chaiscript AST_Node(t_ast_node_text, t_id, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ try { t_ss.add_object(this->children[0]->text, Boxed_Value()); } @@ -1121,7 +1121,7 @@ namespace chaiscript { } virtual ~Prefix_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ chaiscript::eval::detail::Function_Push_Pop fpp(t_ss); Boxed_Value bv(this->children[1]->eval(t_ss)); @@ -1150,7 +1150,7 @@ namespace chaiscript Break_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Break, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Break_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &) override{ throw detail::Break_Loop(); } }; @@ -1160,7 +1160,7 @@ namespace chaiscript Continue_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Continue, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Continue_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &) override{ throw detail::Continue_Loop(); } }; @@ -1173,7 +1173,7 @@ namespace chaiscript { } virtual ~Noop_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &) override{ // It's a no-op, that evaluates to "true" return m_value; } @@ -1201,7 +1201,7 @@ namespace chaiscript Inline_Range_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Inline_Range, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Inline_Range_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ try { return t_ss.call_function("generate_range", this->children[0]->children[0]->children[0]->eval(t_ss), @@ -1226,7 +1226,7 @@ namespace chaiscript Try_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Try, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Try_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ Boxed_Value retval; chaiscript::eval::detail::Scope_Push_Pop spp(t_ss); @@ -1369,7 +1369,7 @@ namespace chaiscript Method_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Method, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Method_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ std::vector t_param_names; AST_NodePtr guardnode; @@ -1452,7 +1452,7 @@ namespace chaiscript Attr_Decl_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Attr_Decl, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Attr_Decl_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ try { t_ss.add(Proxy_Function @@ -1516,7 +1516,7 @@ namespace chaiscript Logical_And_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Logical_And, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Logical_And_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ Boxed_Value retval = this->children[0]->eval(t_ss); if (this->children.size() > 1) { @@ -1539,7 +1539,7 @@ namespace chaiscript return retval; } - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { return "(" + AST_Node::pretty_print() + ")"; } @@ -1550,7 +1550,7 @@ namespace chaiscript Logical_Or_AST_Node(const std::string &t_ast_node_text = "", const std::shared_ptr &t_fname=std::shared_ptr(), int t_start_line = 0, int t_start_col = 0, int t_end_line = 0, int t_end_col = 0) : AST_Node(t_ast_node_text, AST_Node_Type::Logical_Or, t_fname, t_start_line, t_start_col, t_end_line, t_end_col) { } virtual ~Logical_Or_AST_Node() {} - virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss){ + virtual Boxed_Value eval_internal(chaiscript::detail::Dispatch_Engine &t_ss) override{ Boxed_Value retval; retval = this->children[0]->eval(t_ss); @@ -1570,7 +1570,7 @@ namespace chaiscript return retval; } - virtual std::string pretty_print() const + virtual std::string pretty_print() const override { return "(" + AST_Node::pretty_print() + ")"; } diff --git a/include/chaiscript/language/chaiscript_parser.hpp b/include/chaiscript/language/chaiscript_parser.hpp index 71334d5..b29b8ef 100644 --- a/include/chaiscript/language/chaiscript_parser.hpp +++ b/include/chaiscript/language/chaiscript_parser.hpp @@ -135,8 +135,8 @@ namespace chaiscript m_operator_matches.push_back(multiplication); for ( int c = 0 ; c < detail::lengthof_alphabet ; ++c ) { - for ( int a = 0 ; a < detail::max_alphabet ; a ++ ) { - m_alphabet[a][c]=false; + for (auto & elem : m_alphabet) { + elem[c]=false; } } m_alphabet[detail::symbol_alphabet][static_cast('?')]=true; @@ -212,9 +212,9 @@ namespace chaiscript * Shows the current stack of matched ast_nodes */ void show_match_stack() { - for (unsigned int i = 0; i < m_match_stack.size(); ++i) { + for (auto & elem : m_match_stack) { //debug_print(match_stack[i]); - std::cout << m_match_stack[i]->to_string(); + std::cout << elem->to_string(); } } @@ -2062,8 +2062,8 @@ namespace chaiscript } bool Operator_Helper(size_t t_precedence) { - for (size_t i = 0; i < m_operator_matches[t_precedence].size(); ++i) { - if (Symbol(m_operator_matches[t_precedence][i].c_str(), true)) { + for (auto & elem : m_operator_matches[t_precedence]) { + if (Symbol(elem.c_str(), true)) { return true; } } diff --git a/src/main.cpp b/src/main.cpp index c8d98e7..72da7fc 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -33,7 +33,7 @@ char* readline(const char* p) std::string retval; std::cout << p ; std::getline(std::cin, retval); - return std::cin.eof() ? NULL : mystrdup(retval.c_str()); + return std::cin.eof() ? nullptr : mystrdup(retval.c_str()); } diff --git a/src/test_module.cpp b/src/test_module.cpp index f878579..284fb6f 100644 --- a/src/test_module.cpp +++ b/src/test_module.cpp @@ -36,7 +36,7 @@ class TestDerivedType : public TestBaseType { public: virtual ~TestDerivedType() {} - virtual int func() { return 1; } + virtual int func() override { return 1; } int derived_only_func() { return 19; } private: