- Fix legit threading issue which shows itself on clang / macos mostly

- Fix all warnings that I can / ignore those caused by boost

include/chaiscript/dispatchkit/boxed_value.hpp

@@ -13,7 +13,19 @@
 
 #include <map>
 #include <boost/shared_ptr.hpp>
+
+#ifdef __llvm__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wshadow"
+#pragma clang diagnostic ignored "-Wunused-parameter"
+#endif
+
 #include <boost/make_shared.hpp>
+
+#ifdef __llvm__
+#pragma clang diagnostic pop
+#endif
+
 #include <boost/any.hpp>
 #include <boost/function.hpp>
 #include <boost/ref.hpp>

include/chaiscript/dispatchkit/exception_specification.hpp

@@ -17,6 +17,8 @@ namespace chaiscript
     {
       virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine) = 0;
 
+      virtual ~Exception_Handler_Base() {}
+
       protected:
         template<typename T>
         void throw_type(const Boxed_Value &bv, const Dispatch_Engine &t_engine)
@@ -28,6 +30,8 @@ namespace chaiscript
     template<typename T1>
       struct Exception_Handler_Impl1 : Exception_Handler_Base
       {
+        virtual ~Exception_Handler_Impl1() {}
+
         virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine)
         {
           throw_type<T1>(bv, t_engine);
@@ -36,6 +40,8 @@ namespace chaiscript
     template<typename T1, typename T2>
       struct Exception_Handler_Impl2 : Exception_Handler_Base
       {
+        virtual ~Exception_Handler_Impl2() {}
+
         virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine)
         {
           throw_type<T1>(bv, t_engine);
@@ -46,6 +52,8 @@ namespace chaiscript
     template<typename T1, typename T2, typename T3>
       struct Exception_Handler_Impl3 : Exception_Handler_Base
       {
+        virtual ~Exception_Handler_Impl3() {}
+
         virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine)
         {
           throw_type<T1>(bv, t_engine);
@@ -56,6 +64,8 @@ namespace chaiscript
     template<typename T1, typename T2, typename T3, typename T4>
       struct Exception_Handler_Impl4 : Exception_Handler_Base
       {
+        virtual ~Exception_Handler_Impl4() {}
+
         virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine)
         {
           throw_type<T1>(bv, t_engine);
@@ -67,6 +77,8 @@ namespace chaiscript
     template<typename T1, typename T2, typename T3, typename T4, typename T5>
       struct Exception_Handler_Impl5 : Exception_Handler_Base
       {
+        virtual ~Exception_Handler_Impl5() {}
+
         virtual void handle(const Boxed_Value &bv, const Dispatch_Engine &t_engine)
         {
           throw_type<T1>(bv, t_engine);

include/chaiscript/dispatchkit/proxy_functions_detail.hpp

@@ -86,9 +86,16 @@ namespace chaiscript
        * if any unboxing fails the execution of the function fails and
        * the bad_boxed_cast is passed up to the caller.
        */
+#ifdef __llvm__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
+#endif
       template<typename Ret BOOST_PP_COMMA_IF(n) BOOST_PP_ENUM_PARAMS(n, typename Param)>
         Ret call_func(const boost::function<Ret (BOOST_PP_ENUM_PARAMS(n, Param))> &f,
-            const std::vector<Boxed_Value> &params, const Dynamic_Cast_Conversions & BOOST_PP_IF(n, t_conversions, ))
+            const std::vector<Boxed_Value> &params, const Dynamic_Cast_Conversions & BOOST_PP_IF(n, t_conversions, BOOST_PP_EMPTY))
+#ifdef __llvm__
+#pragma clang diagnostic pop
+#endif
         {
           if (params.size() != n)
           {
@@ -103,9 +110,17 @@ namespace chaiscript
        * Proxy_Function_Impl object. This function is primarly used to prevent
        * registration of two functions with the exact same signatures
        */
-      template<typename Ret BOOST_PP_COMMA_IF(n) BOOST_PP_ENUM_PARAMS(n, typename Param)>
+
+#ifdef __llvm__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
+#endif
+       template<typename Ret BOOST_PP_COMMA_IF(n) BOOST_PP_ENUM_PARAMS(n, typename Param)>
         bool compare_types_cast(Ret (*)(BOOST_PP_ENUM_PARAMS(n, Param)),
-            const std::vector<Boxed_Value> & BOOST_PP_IF(n, params, ), const Dynamic_Cast_Conversions &t_conversions)
+            const std::vector<Boxed_Value> & BOOST_PP_IF(n, params, BOOST_PP_EMPTY), const Dynamic_Cast_Conversions &t_conversions)
+#ifdef __llvm__
+#pragma clang diagnostic pop
+#endif
         {
           try {
             (void)t_conversions;