From f982c8da948a66f3b16ef46d56b8f9e39161f9b9 Mon Sep 17 00:00:00 2001 From: Edouard DUPIN Date: Wed, 20 Jul 2016 21:10:06 +0200 Subject: [PATCH] [DEV] set some const --- exml/AttributeList.cpp | 2 +- exml/AttributeList.h | 2 +- exml/Element.cpp | 2 +- exml/Element.h | 2 +- exml/internal/Element.cpp | 8 ++++++++ exml/internal/Element.h | 8 ++------ test/exmlTestElement.cpp | 1 + 7 files changed, 15 insertions(+), 10 deletions(-) diff --git a/exml/AttributeList.cpp b/exml/AttributeList.cpp index ac05b84..4a2c881 100644 --- a/exml/AttributeList.cpp +++ b/exml/AttributeList.cpp @@ -9,7 +9,7 @@ #include -exml::AttributeList::AttributeList(ememory::SharedPtr _internalNode) : +exml::AttributeList::AttributeList(const ememory::SharedPtr& _internalNode) : exml::Node(_internalNode), attributes(this) { diff --git a/exml/AttributeList.h b/exml/AttributeList.h index 976c120..077f751 100644 --- a/exml/AttributeList.h +++ b/exml/AttributeList.h @@ -112,7 +112,7 @@ namespace exml { * @brief basic element of a xml structure * @param[in] _internalNode Value of the node */ - AttributeList(ememory::SharedPtr _internalNode); + AttributeList(const ememory::SharedPtr& _internalNode); /** * @brief basic element of a xml structure */ diff --git a/exml/Element.cpp b/exml/Element.cpp index b67e0f6..bc93b40 100644 --- a/exml/Element.cpp +++ b/exml/Element.cpp @@ -9,7 +9,7 @@ #include -exml::Element::Element(ememory::SharedPtr _internalNode) : +exml::Element::Element(const ememory::SharedPtr& _internalNode) : exml::AttributeList(_internalNode), nodes(this) { if (m_data == nullptr) { diff --git a/exml/Element.h b/exml/Element.h index 7d2f42c..8028974 100644 --- a/exml/Element.h +++ b/exml/Element.h @@ -106,7 +106,7 @@ namespace exml { * @brief Constructor * @param[in] _internalNode Internal Node to set data */ - Element(ememory::SharedPtr _internalNode); + Element(const ememory::SharedPtr& _internalNode); /** * @brief Copy constructor * @param[in] _obj Object to copy diff --git a/exml/internal/Element.cpp b/exml/internal/Element.cpp index a4a12be..661cefe 100644 --- a/exml/internal/Element.cpp +++ b/exml/internal/Element.cpp @@ -503,3 +503,11 @@ void exml::internal::Element::clear() { } +ememory::SharedPtr exml::internal::Element::toElement() { + return ememory::staticPointerCast(sharedFromThis()); +} + +const ememory::SharedPtr exml::internal::Element::toElement() const { + return ememory::staticPointerCast(sharedFromThis()); +} + diff --git a/exml/internal/Element.h b/exml/internal/Element.h index b4ddd4a..57456dd 100644 --- a/exml/internal/Element.h +++ b/exml/internal/Element.h @@ -126,12 +126,8 @@ namespace exml { } bool iParse(const std::string& _data, int32_t& _pos, bool _caseSensitive, exml::FilePos& _filePos, exml::internal::Document& _doc) override; bool iGenerate(std::string& _data, int32_t _indent) const override; - ememory::SharedPtr toElement() override { - return ememory::staticPointerCast(sharedFromThis()); - } - const ememory::SharedPtr toElement() const override { - return ememory::staticPointerCast(sharedFromThis()); - } + ememory::SharedPtr toElement() override; + const ememory::SharedPtr toElement() const override; void clear() override; }; } diff --git a/test/exmlTestElement.cpp b/test/exmlTestElement.cpp index 50ffc66..f9ced79 100644 --- a/test/exmlTestElement.cpp +++ b/test/exmlTestElement.cpp @@ -5,6 +5,7 @@ */ #include +#include #include #include #include