From aaa1d12c68cf5a265186c95f55cdd50a922a0901 Mon Sep 17 00:00:00 2001 From: Samuel Gaist Date: Thu, 6 Nov 2014 00:34:21 +0100 Subject: [PATCH] Use const references rather than just const --- QSimpleUpdater/src/qsimpleupdater.cpp | 10 +++++----- QSimpleUpdater/src/qsimpleupdater.h | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/QSimpleUpdater/src/qsimpleupdater.cpp b/QSimpleUpdater/src/qsimpleupdater.cpp index ec04511..da31193 100755 --- a/QSimpleUpdater/src/qsimpleupdater.cpp +++ b/QSimpleUpdater/src/qsimpleupdater.cpp @@ -107,7 +107,7 @@ bool QSimpleUpdater::newerVersionAvailable() { return m_new_version_available; } -void QSimpleUpdater::setDownloadUrl(const QString url) { +void QSimpleUpdater::setDownloadUrl(const QString &url) { // Change the download URL if the issued URL is valid if (!url.isEmpty()) { m_download_url.setUrl(url); @@ -119,7 +119,7 @@ void QSimpleUpdater::setDownloadUrl(const QString url) { } } -void QSimpleUpdater::setReferenceUrl(const QString url) { +void QSimpleUpdater::setReferenceUrl(const QString &url) { // Change the reference URL if the issued URL is valid if (!url.isEmpty()) { m_reference_url.setUrl(url); @@ -131,7 +131,7 @@ void QSimpleUpdater::setReferenceUrl(const QString url) { } } -void QSimpleUpdater::setChangelogUrl(const QString url) { +void QSimpleUpdater::setChangelogUrl(const QString &url) { // Change the changelog URL if the issued URL is valid if (!url.isEmpty()) { m_changelog_url.setUrl(url); @@ -143,7 +143,7 @@ void QSimpleUpdater::setChangelogUrl(const QString url) { } } -void QSimpleUpdater::setApplicationVersion(const QString version) { +void QSimpleUpdater::setApplicationVersion(const QString &version) { // Change the installed application version if the issued string is valid if (!version.isEmpty()) { m_installed_version = version; @@ -264,6 +264,6 @@ void QSimpleUpdater::processDownloadedChangelog(QNetworkReply *reply) { emit checkingFinished(); } -void QSimpleUpdater::ignoreSslErrors (QNetworkReply *reply, QList error) { +void QSimpleUpdater::ignoreSslErrors (QNetworkReply *reply, const QList &error) { reply->ignoreSslErrors (error); } diff --git a/QSimpleUpdater/src/qsimpleupdater.h b/QSimpleUpdater/src/qsimpleupdater.h index ededa7e..24f2609 100755 --- a/QSimpleUpdater/src/qsimpleupdater.h +++ b/QSimpleUpdater/src/qsimpleupdater.h @@ -27,15 +27,15 @@ public: bool newerVersionAvailable(); public slots: - void setDownloadUrl(const QString url); - void setReferenceUrl(const QString url); - void setChangelogUrl(const QString url); - void setApplicationVersion(const QString version); + void setDownloadUrl(const QString &url); + void setReferenceUrl(const QString &url); + void setChangelogUrl(const QString &url); + void setApplicationVersion(const QString &version); private slots: void checkDownloadedVersion(QNetworkReply *reply); void processDownloadedChangelog(QNetworkReply *reply); - void ignoreSslErrors(QNetworkReply *reply, QList error); + void ignoreSslErrors(QNetworkReply *reply, const QList &error); signals: void checkingFinished();